summary refs log tree commit diff
path: root/changelog.d
diff options
context:
space:
mode:
authorAndrew Morgan <1342360+anoadragon453@users.noreply.github.com>2020-12-30 19:27:32 +0000
committerGitHub <noreply@github.com>2020-12-30 19:27:32 +0000
commit168ba00d0138c3a0f44d07370f97dd854177794f (patch)
tree495b24d16abe83f1ad6d495e186c7ac703458a81 /changelog.d
parentCheck if group IDs are valid before using them. (#8977) (diff)
downloadsynapse-168ba00d0138c3a0f44d07370f97dd854177794f.tar.xz
Fix RoomDirectoryFederationTests and make them actually run (#8998)
The `RoomDirectoryFederationTests` tests were not being run unless explicitly called as an `__init__.py` file was not present in `tests/federation/transport/`. Thus the folder was not a python module, and `trial` did not look inside for any test cases to run. This was found while working on #6739.

This PR adds a `__init__.py` and also fixes the test in a couple ways:

- Switch to subclassing `unittest.FederatingHomeserverTestCase` instead, which sets up federation endpoints for us.
- Supply a `federation_auth_origin` to `make_request` in order to more act like the request is coming from another server, instead of just an unauthenicated client requesting a federation endpoint.

I found that the second point makes no difference to the test passing, but felt like the right thing to do if we're testing over federation.
Diffstat (limited to 'changelog.d')
-rw-r--r--changelog.d/8998.misc1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/8998.misc b/changelog.d/8998.misc
new file mode 100644
index 0000000000..81346694bd
--- /dev/null
+++ b/changelog.d/8998.misc
@@ -0,0 +1 @@
+Fix `tests.federation.transport.RoomDirectoryFederationTests` and ensure it runs in CI.
\ No newline at end of file