diff options
| author | kegsay <kegan@matrix.org> | 2022-01-25 15:05:22 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-25 15:05:22 +0000 |
| commit | 0938f32e937f6e37002fc87c711ec7a5515eb880 (patch) | |
| tree | d73d2fc2375d9da2683d0c3e1e239fe548d29848 /changelog.d | |
| parent | Log modules at startup (#11813) (diff) | |
| download | synapse-0938f32e937f6e37002fc87c711ec7a5515eb880.tar.xz | |
CI: run Complement on the VM, not inside Docker (#11811)
* CI: run Complement on the VM, not inside Docker This requires https://github.com/matrix-org/complement/pull/289 We now run Complement on the VM instead of inside a Docker container. This is to allow Complement to bind to any high-numbered port when it starts up its own federation servers. We want to do this to allow for more concurrency when running complement tests. Previously, Complement only ever bound to `:8448` when running its own federation server. This prevented multiple federation tests running at the same time as they would fight each other on the port. This did however allow Complement to run in Docker, as the host could just port forward `:8448` to allow homeserver containers to communicate to Complement. Now that we are using random ports however, we cannot use Docker to run Complement. This ends up being a good thing because: - Running Complement tests locally is closer to how they run in CI. - Allows the `CI` env var to be removed in Complement. - Slightly speeds up runs as we don't need to pull down the Complement image prior to running tests. This assumes GHA caches actions sensibly. * Changelog * Full stop * Update .github/workflows/tests.yml Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Review comments * Update .github/workflows/tests.yml Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/11811.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/11811.misc b/changelog.d/11811.misc new file mode 100644 index 0000000000..b911a2d042 --- /dev/null +++ b/changelog.d/11811.misc @@ -0,0 +1 @@ +Run Complement on the Github Actions VM and not inside a Docker container. \ No newline at end of file |