summary refs log tree commit diff
path: root/changelog.d
diff options
context:
space:
mode:
authorEric Eastwood <erice@element.io>2022-08-09 14:32:33 -0500
committerGitHub <noreply@github.com>2022-08-09 14:32:33 -0500
commit1b09b0832ed56bfc994deadb3315755d0c20433b (patch)
treed9c1631d8f7028599d095a49a30a51227c5b391c /changelog.d
parentUse literals in place of `HTTPStatus` constants in tests (#13479) (diff)
downloadsynapse-1b09b0832ed56bfc994deadb3315755d0c20433b.tar.xz
Allow use of both `@trace` and `@tag_args` stacked on the same function (#13453)
```py
@trace
@tag_args
async def get_oldest_event_ids_with_depth_in_room(...)
  ...
```

Before this PR, you would see a warning in the logs and the span was not exported:
```
2022-08-03 19:11:59,383 - synapse.logging.opentracing - 835 - ERROR - GET-0 - @trace may not have wrapped EventFederationWorkerStore.get_oldest_event_ids_with_depth_in_room correctly! The function is not async but returned a coroutine.
```
Diffstat (limited to 'changelog.d')
-rw-r--r--changelog.d/13453.misc1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/13453.misc b/changelog.d/13453.misc
new file mode 100644
index 0000000000..d30c5230c8
--- /dev/null
+++ b/changelog.d/13453.misc
@@ -0,0 +1 @@
+Allow use of both `@trace` and `@tag_args` stacked on the same function (tracing).