diff options
author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-07-11 11:06:23 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-07-11 11:06:23 +0100 |
commit | 0a4001eba1eb22fc7c39f257c8d5a326b1a489ad (patch) | |
tree | 6aa2355d6d132d294c80599bf461e67d70b1ef85 /changelog.d | |
parent | Add basic opentracing support (#5544) (diff) | |
download | synapse-0a4001eba1eb22fc7c39f257c8d5a326b1a489ad.tar.xz |
Clean up exception handling for access_tokens (#5656)
First of all, let's get rid of `TOKEN_NOT_FOUND_HTTP_STATUS`. It was a hack we did at one point when it was possible to return either a 403 or a 401 if the creds were missing. We always return a 401 in these cases now (thankfully), so it's not needed. Let's also stop abusing `AuthError` for these cases. Honestly they have nothing that relates them to the other places that `AuthError` is used, other than the fact that they are loosely under the 'Auth' banner. It makes no sense for them to share exception classes. Instead, let's add a couple of new exception classes: `InvalidClientTokenError` and `MissingClientTokenError`, for the `M_UNKNOWN_TOKEN` and `M_MISSING_TOKEN` cases respectively - and an `InvalidClientCredentialsError` base class for the two of them.
Diffstat (limited to 'changelog.d')
-rw-r--r-- | changelog.d/5656.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/5656.misc b/changelog.d/5656.misc new file mode 100644 index 0000000000..a8de20a7d0 --- /dev/null +++ b/changelog.d/5656.misc @@ -0,0 +1 @@ +Clean up exception handling around client access tokens. |