diff options
author | Sean Quah <8349537+squahtx@users.noreply.github.com> | 2022-05-09 12:31:14 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-09 12:31:14 +0100 |
commit | a00462dd9927558532b030593f8914ade53b7214 (patch) | |
tree | d15933417e46d7b451298238b39bced69ebffa0b /changelog.d | |
parent | Fix mypy against latest pillow stubs (#12671) (diff) | |
download | synapse-a00462dd9927558532b030593f8914ade53b7214.tar.xz |
Implement cancellation support/protection for module callbacks (#12568)
There's no guarantee that module callbacks will handle cancellation appropriately. Protect module callbacks with read semantics from cancellation and avoid swallowing `CancelledError`s that arise. Other module callbacks, such as the `on_*` callbacks, are presumed to live on code paths that involve writes and aren't cancellation-friendly. These module callbacks have been left alone. Signed-off-by: Sean Quah <seanq@element.io>
Diffstat (limited to 'changelog.d')
-rw-r--r-- | changelog.d/12568.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/12568.misc b/changelog.d/12568.misc new file mode 100644 index 0000000000..f64dc67c4f --- /dev/null +++ b/changelog.d/12568.misc @@ -0,0 +1 @@ +Protect module callbacks with read semantics against cancellation. |