diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2021-12-20 17:45:03 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-20 17:45:03 +0000 |
| commit | 60fa4935b5d3ee26f9ebb4b25ec74bed26d3c98d (patch) | |
| tree | 0d7b224898e28fa16022e1062911e5efd3da164d /changelog.d | |
| parent | Merge remote-tracking branch 'origin/release-v1.49' into develop (diff) | |
| download | synapse-60fa4935b5d3ee26f9ebb4b25ec74bed26d3c98d.tar.xz | |
Improve opentracing for incoming HTTP requests (#11618)
* remove `start_active_span_from_request` Instead, pull out a separate function, `span_context_from_request`, to extract the parent span, which we can then pass into `start_active_span` as normal. This seems to be clearer all round. * Remove redundant tags from `incoming-federation-request` These are all wrapped up inside a parent span generated in AsyncResource, so there's no point duplicating all the tags that are set there. * Leave request spans open until the request completes It may take some time for the response to be encoded into JSON, and that JSON to be streamed back to the client, and really we want that inside the top-level span, so let's hand responsibility for closure to the SynapseRequest. * opentracing logs for HTTP request events * changelog
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/11618.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/11618.misc b/changelog.d/11618.misc new file mode 100644 index 0000000000..4076b30bf7 --- /dev/null +++ b/changelog.d/11618.misc @@ -0,0 +1 @@ +Improve opentracing support for incoming HTTP requests. |