summary refs log tree commit diff
path: root/changelog.d
diff options
context:
space:
mode:
authorSean Quah <8349537+squahtx@users.noreply.github.com>2023-01-31 11:03:55 +0000
committerGitHub <noreply@github.com>2023-01-31 11:03:55 +0000
commit6d14fdc2710688014a7a66cc48485462c6e86a1e (patch)
tree45d6a2a185e0bb7832504892d319f89265df30c3 /changelog.d
parentReject boolean power levels (#14944) (diff)
downloadsynapse-6d14fdc2710688014a7a66cc48485462c6e86a1e.tar.xz
Make sqlite database migrations transactional again, part two (#14926)
#14910 fixed the regression introduced by #13873 where sqlite database
migrations would no longer run inside a transaction. However, it
committed the transaction before Synapse updated its bookkeeping of
which migrations have been run, which means that migrations may be run
again after they have completed successfully.

Leave the transaction open at the end of `executescript`, to restore the
old, correct behaviour. Also make the PostgreSQL behaviour consistent
with SQLite.

Fixes #14909.

Signed-off-by: Sean Quah <seanq@matrix.org>
Diffstat (limited to 'changelog.d')
-rw-r--r--changelog.d/14926.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/14926.bugfix b/changelog.d/14926.bugfix
new file mode 100644
index 0000000000..f1f34cd6ba
--- /dev/null
+++ b/changelog.d/14926.bugfix
@@ -0,0 +1 @@
+Fix a regression introduced in Synapse 1.69.0 which can result in database corruption when database migrations are interrupted on sqlite.