diff options
| author | Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | 2020-10-20 11:47:24 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-20 11:47:24 +0100 |
| commit | a312e890f5b5746f991b07970dd92d680e08dd4c (patch) | |
| tree | cb9cb44413f6c2bb4ba4306f2caa30ac16158156 /changelog.d | |
| parent | Move schema file for as_device_stream (#8590) (diff) | |
| download | synapse-a312e890f5b5746f991b07970dd92d680e08dd4c.tar.xz | |
Cast errors generated during synapse_port_db to str (#8585)
I noticed in https://github.com/matrix-org/synapse/issues/8575 that the `end_error` variable in `synapse_port_db` is set to an `Exception`, even though later we expect it to be a `str`. This PR simply casts an exception raised to a string. I'm doing this instead of having `end_error` be of type exception as we explicitly set `end_error` to a str here: https://github.com/matrix-org/synapse/blob/d25eb8f3709965d0face01a041d5292490bf0139/scripts/synapse_port_db#L542-L547 This whole file could probably use some heavy refactoring, but until then at least this fix will prevent exception contents from being hidden from us and users.
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/8585.bugfix | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/8585.bugfix b/changelog.d/8585.bugfix new file mode 100644 index 0000000000..e97e6ac1d8 --- /dev/null +++ b/changelog.d/8585.bugfix @@ -0,0 +1 @@ +Fix a bug that prevented errors encountered during execution of the `synapse_port_db` from being correctly printed. \ No newline at end of file |