diff options
| author | Eric Eastwood <erice@element.io> | 2022-09-28 15:26:16 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-28 15:26:16 -0500 |
| commit | df8b91ed2bba4995c59a5b067e3b252ab90c9a5e (patch) | |
| tree | 86a088bd2194b23a0dea145e0c6bb5b083294d12 /changelog.d | |
| parent | Add upgrade notes for changes to receipts replication. (#13932) (diff) | |
| download | synapse-df8b91ed2bba4995c59a5b067e3b252ab90c9a5e.tar.xz | |
Limit and filter the number of backfill points to get from the database (#13879)
There is no need to grab thousands of backfill points when we only need 5 to make the `/backfill` request with. We need to grab a few extra in case the first few aren't visible in the history. Previously, we grabbed thousands of backfill points from the database, then sorted and filtered them in the app. Fetching the 4.6k backfill points for `#matrix:matrix.org` from the database takes ~50ms - ~570ms so it's not like this saves a lot of time 🤷. But it might save us more time now that `get_backfill_points_in_room`/`get_insertion_event_backward_extremities_in_room` are more complicated after https://github.com/matrix-org/synapse/pull/13635 This PR moves the filtering and limiting to the SQL query so we just have less data to work with in the first place. Part of https://github.com/matrix-org/synapse/issues/13356
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/13879.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/13879.misc b/changelog.d/13879.misc new file mode 100644 index 0000000000..3cc2a2420f --- /dev/null +++ b/changelog.d/13879.misc @@ -0,0 +1 @@ +Only pull relevant backfill points from the database based on the current depth and limit (instead of all) every time we want to `/backfill`. |