summary refs log tree commit diff
path: root/changelog.d
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2019-07-17 16:52:02 +0100
committerGitHub <noreply@github.com>2019-07-17 16:52:02 +0100
commit375162b3c36482b006d28ab8bf719617945c4b1e (patch)
treee8ee082bca801ddca6b3cbd04129f02791c96406 /changelog.d
parentRefactor `get_events_as_list` (#5699) (diff)
downloadsynapse-375162b3c36482b006d28ab8bf719617945c4b1e.tar.xz
Fix redaction authentication (#5700)
Ensures that redactions are correctly authenticated for recent room versions.

There are a few things going on here:

 * `_fetch_event_rows` is updated to return a dict rather than a list of rows.

 * Rather than returning multiple copies of an event which was redacted
   multiple times, it returns the redactions as a list within the dict.

 * It also returns the actual rejection reason, rather than merely the fact
   that it was rejected, so that we don't have to query the table again in
   `_get_event_from_row`.

 * The redaction handling is factored out of `_get_event_from_row`, and now
   checks if any of the redactions are valid.
Diffstat (limited to 'changelog.d')
-rw-r--r--changelog.d/5700.bugfix2
1 files changed, 2 insertions, 0 deletions
diff --git a/changelog.d/5700.bugfix b/changelog.d/5700.bugfix
new file mode 100644
index 0000000000..51bce8d441
--- /dev/null
+++ b/changelog.d/5700.bugfix
@@ -0,0 +1,2 @@
+Fix some problems with authenticating redactions in recent room versions.
+