diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2021-01-12 12:34:16 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-12 12:34:16 +0000 |
| commit | 2ec8ca5e6046b207eabe008101631b978758ac6d (patch) | |
| tree | 009a9eceb2fa4b08132536b7412213379ef9340f /changelog.d/9069.misc | |
| parent | Also support remote users on the joined_rooms admin API. (#8948) (diff) | |
| download | synapse-2ec8ca5e6046b207eabe008101631b978758ac6d.tar.xz | |
Remove SynapseRequest.get_user_agent (#9069)
SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests", which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the LoggingContext and write the right entries to the request log). Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a SynapseRequest when there is nothing synapse-specific about the Request at all, and any old twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult. In short: move get_user_agent out to a utility function.
Diffstat (limited to 'changelog.d/9069.misc')
| -rw-r--r-- | changelog.d/9069.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/9069.misc b/changelog.d/9069.misc new file mode 100644 index 0000000000..5e9e62d252 --- /dev/null +++ b/changelog.d/9069.misc @@ -0,0 +1 @@ +Remove `SynapseRequest.get_user_agent`. |