summary refs log tree commit diff
path: root/changelog.d/8916.misc
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2020-12-14 11:38:50 +0000
committerGitHub <noreply@github.com>2020-12-14 11:38:50 +0000
commit895e04319ba457a855207b8bb804f7360a258464 (patch)
treebb2c6be9e022d09eb31a7e964fa691b4fef856f2 /changelog.d/8916.misc
parentAllow spam-checker modules to be provide async methods. (#8890) (diff)
downloadsynapse-895e04319ba457a855207b8bb804f7360a258464.tar.xz
Preparatory refactoring of the OidcHandlerTestCase (#8911)
* Remove references to handler._auth_handler

(and replace them with hs.get_auth_handler)

* Factor out a utility function for building Requests

* Remove mocks of `OidcHandler._map_userinfo_to_user`

This method is going away, so mocking it out is no longer a valid approach.

Instead, we mock out lower-level methods (eg _remote_id_from_userinfo), or
simply allow the regular implementation to proceed and update the expectations
accordingly.

* Remove references to `OidcHandler._map_userinfo_to_user` from tests

This method is going away, so we can no longer use it as a test point. Instead
we build mock "callback" requests which we pass into `handle_oidc_callback`,
and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`.

Diffstat (limited to 'changelog.d/8916.misc')
0 files changed, 0 insertions, 0 deletions