diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2020-10-09 17:22:25 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-09 17:22:25 +0100 |
| commit | 9789b1fba541a5ae01b946770416729e5b7e5b7e (patch) | |
| tree | 6f09495a7e7c180444fb1f9d9e186c3f384c56ba /changelog.d/8497.misc | |
| parent | Increase default max_upload_size from 10M to 50M (#8502) (diff) | |
| download | synapse-9789b1fba541a5ae01b946770416729e5b7e5b7e.tar.xz | |
Fix threadsafety in ThreadedMemoryReactorClock (#8497)
This could, very occasionally, cause:
```
tests.test_visibility.FilterEventsForServerTestCase.test_large_room
===============================================================================
[ERROR]
Traceback (most recent call last):
File "/src/tests/rest/media/v1/test_media_storage.py", line 86, in test_ensure_media_is_in_local_cache
self.wait_on_thread(x)
File "/src/tests/unittest.py", line 296, in wait_on_thread
self.reactor.advance(0.01)
File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 826, in advance
self._sortCalls()
File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 787, in _sortCalls
self.calls.sort(key=lambda a: a.getTime())
builtins.ValueError: list modified during sort
tests.rest.media.v1.test_media_storage.MediaStorageTests.test_ensure_media_is_in_local_cache
```Diffstat (limited to 'changelog.d/8497.misc')
| -rw-r--r-- | changelog.d/8497.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/8497.misc b/changelog.d/8497.misc new file mode 100644 index 0000000000..8bc05e8df6 --- /dev/null +++ b/changelog.d/8497.misc @@ -0,0 +1 @@ +Fix a threadsafety bug in unit tests. |