summary refs log tree commit diff
path: root/changelog.d/8433.misc
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2020-10-09 17:22:25 +0100
committerGitHub <noreply@github.com>2020-10-09 17:22:25 +0100
commit9789b1fba541a5ae01b946770416729e5b7e5b7e (patch)
tree6f09495a7e7c180444fb1f9d9e186c3f384c56ba /changelog.d/8433.misc
parentIncrease default max_upload_size from 10M to 50M (#8502) (diff)
downloadsynapse-9789b1fba541a5ae01b946770416729e5b7e5b7e.tar.xz
Fix threadsafety in ThreadedMemoryReactorClock (#8497)
This could, very occasionally, cause:

```
tests.test_visibility.FilterEventsForServerTestCase.test_large_room
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/src/tests/rest/media/v1/test_media_storage.py", line 86, in test_ensure_media_is_in_local_cache
    self.wait_on_thread(x)
  File "/src/tests/unittest.py", line 296, in wait_on_thread
    self.reactor.advance(0.01)
  File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 826, in advance
    self._sortCalls()
  File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 787, in _sortCalls
    self.calls.sort(key=lambda a: a.getTime())
builtins.ValueError: list modified during sort

tests.rest.media.v1.test_media_storage.MediaStorageTests.test_ensure_media_is_in_local_cache
```
Diffstat (limited to 'changelog.d/8433.misc')
0 files changed, 0 insertions, 0 deletions