summary refs log tree commit diff
path: root/changelog.d/8398.bugfix
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2020-09-25 12:29:54 +0100
committerGitHub <noreply@github.com>2020-09-25 12:29:54 +0100
commitfec6f9ac178867a8e7c5410e0d25898f29bab35c (patch)
treeab127833049cd146c96a2fea7c85f116c26ec3ea /changelog.d/8398.bugfix
parentAllow existing users to login via OpenID Connect. (#8345) (diff)
downloadsynapse-fec6f9ac178867a8e7c5410e0d25898f29bab35c.tar.xz
Fix occasional "Re-starting finished log context" from keyring (#8398)
* Fix test_verify_json_objects_for_server_awaits_previous_requests

It turns out that this wasn't really testing what it thought it was testing
(in particular, `check_context` was turning failures into success, which was
making the tests pass even though it wasn't clear they should have been.

It was also somewhat overcomplex - we can test what it was trying to test
without mocking out perspectives servers.

* Fix warnings about finished logcontexts in the keyring

We need to make sure that we finish the key fetching magic before we run the
verifying code, to ensure that we don't mess up our logcontexts.
Diffstat (limited to 'changelog.d/8398.bugfix')
-rw-r--r--changelog.d/8398.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/8398.bugfix b/changelog.d/8398.bugfix
new file mode 100644
index 0000000000..e432aeebf1
--- /dev/null
+++ b/changelog.d/8398.bugfix
@@ -0,0 +1 @@
+Fix "Re-starting finished log context" warning when receiving an event we already had over federation.