summary refs log tree commit diff
path: root/changelog.d/8394.bugfix
diff options
context:
space:
mode:
authorAndrew Morgan <1342360+anoadragon453@users.noreply.github.com>2020-09-24 16:24:08 +0100
committerGitHub <noreply@github.com>2020-09-24 16:24:08 +0100
commit3f4a2a7064f79e77deaed8be96668020abef3c9d (patch)
tree6251e639ff8412b2a831031e6c2ed9a808a42ba1 /changelog.d/8394.bugfix
parentFix wording of deprecation notice in changelog (diff)
downloadsynapse-3f4a2a7064f79e77deaed8be96668020abef3c9d.tar.xz
Hotfix: disable autoescape by default when rendering Jinja2 templates (#8394)
#8037 changed the default `autoescape` option when rendering Jinja2 templates from `False` to `True`. This caused some bugs, noticeably around redirect URLs being escaped in SAML2 auth confirmation templates, causing those URLs to break for users.

This change returns the previous behaviour as it stood. We may want to look at each template individually and see whether autoescaping is a good idea at some point, but for now lets just fix the breakage.
Diffstat (limited to 'changelog.d/8394.bugfix')
-rw-r--r--changelog.d/8394.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/8394.bugfix b/changelog.d/8394.bugfix
new file mode 100644

index 0000000000..0ac1eeca0a --- /dev/null +++ b/changelog.d/8394.bugfix
@@ -0,0 +1 @@ +Fix URLs being accidentally escaped in Jinja2 templates. Broke in v1.20.0. \ No newline at end of file