diff options
| author | Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | 2020-08-28 09:58:17 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-28 09:58:17 +0100 |
| commit | 2c2e649be29390061d2bc7d7a7aea1daa32e68f6 (patch) | |
| tree | d0ec1eacb13a9c0cbe3c18b3cc8ddae80d491790 /changelog.d/8182.misc | |
| parent | Do not yield on awaitables in tests. (#8193) (diff) | |
| download | synapse-2c2e649be29390061d2bc7d7a7aea1daa32e68f6.tar.xz | |
Move and refactor LoginRestServlet helper methods (#8182)
This is split out from https://github.com/matrix-org/synapse/pull/7438, which had gotten rather large. `LoginRestServlet` has a couple helper methods, `login_submission_legacy_convert` and `login_id_thirdparty_from_phone`. They're primarily used for converting legacy user login submissions to "identifier" dicts ([see spec](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-login)). Identifying information such as usernames or 3PID information used to be top-level in the login body. They're now supposed to be put inside an [identifier](https://matrix.org/docs/spec/client_server/r0.6.1#identifier-types) parameter instead. #7438's purpose is to allow using the new identifier parameter during User-Interactive Authentication, which is currently handled in AuthHandler. That's why I've moved these helper methods there. I also moved the refactoring of these method from #7438 as they're relevant.
Diffstat (limited to 'changelog.d/8182.misc')
| -rw-r--r-- | changelog.d/8182.misc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/8182.misc b/changelog.d/8182.misc new file mode 100644 index 0000000000..4fcdf1c452 --- /dev/null +++ b/changelog.d/8182.misc @@ -0,0 +1 @@ +Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. \ No newline at end of file |