summary refs log tree commit diff
path: root/changelog.d/7930.feature
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2020-07-23 16:52:33 +0100
committerGitHub <noreply@github.com>2020-07-23 16:52:33 +0100
commit4876af06ddb280b0a01903c1da17466b13124eb3 (patch)
treef1a70f5da23165234a196eddbbdda6f8a0079f04 /changelog.d/7930.feature
parentReorder database docs to promote postgresql. (#7933) (diff)
downloadsynapse-4876af06ddb280b0a01903c1da17466b13124eb3.tar.xz
Abort federation requests if the client disconnects early (#7930)
For inbound federation requests, if a given remote server makes too many
requests at once, we start stacking them up rather than processing them
immediatedly.

However, that means that there is a fair chance that the requesting server will
disconnect before we start processing the request. In that case, if it was a
read-only request (ie, a GET request), there is absolutely no point in
building a response (and some requests are quite expensive to handle).

Even in the case of a POST request, one of two things will happen:

 * Most likely, the requesting server will retry the request and we'll get the
   information anyway.

 * Even if it doesn't, the requesting server has to assume that we didn't get
   the memo, and act accordingly.

In short, we're better off aborting the request at this point rather than
ploughing on with what might be a quite expensive request.
Diffstat (limited to 'changelog.d/7930.feature')
-rw-r--r--changelog.d/7930.feature1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/7930.feature b/changelog.d/7930.feature
new file mode 100644
index 0000000000..a27e4812da
--- /dev/null
+++ b/changelog.d/7930.feature
@@ -0,0 +1 @@
+Abort federation requests where the client disconnects before the ratelimiter expires.