summary refs log tree commit diff
path: root/changelog.d/6491.bugfix
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2019-12-09 11:55:30 +0000
committerGitHub <noreply@github.com>2019-12-09 11:55:30 +0000
commit18660a34d82ccb120efd2fa2480b42ac62dbe2b4 (patch)
tree60503faeb260b59e78f4f02fdcda8f6c7bea5ae8 /changelog.d/6491.bugfix
parentRemove fallback for missing /federation/v1/state_ids API (#6488) (diff)
downloadsynapse-18660a34d82ccb120efd2fa2480b42ac62dbe2b4.tar.xz
Fix inaccurate per-block metrics (#6491)
`Measure` incorrectly assumed that it was the only thing being done by the parent `LoggingContext`. For instance, during a "renew group attestations" operation, hundreds of `outbound_request` calls could take place in parallel, all using the same `LoggingContext`. This would mean that any resources used during *any* of those calls would be reported against *all* of them, producing wildly inaccurate results.

Instead, we now give each `Measure` block its own `LoggingContext` (using the parent `LoggingContext` mechanism to ensure that the log lines look correct and that the metrics are ultimately propogated to the top level for reporting against requests/backgrond tasks).
Diffstat (limited to '')
-rw-r--r--changelog.d/6491.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/6491.bugfix b/changelog.d/6491.bugfix
new file mode 100644
index 0000000000..78204693b0
--- /dev/null
+++ b/changelog.d/6491.bugfix
@@ -0,0 +1 @@
+Fix inaccurate per-block Prometheus metrics.