summary refs log tree commit diff
path: root/changelog.d/4358.misc
diff options
context:
space:
mode:
authorErik Johnston <erikj@jki.re>2019-01-08 11:04:28 +0000
committerRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2019-01-08 11:04:28 +0000
commitb970cb0e9618c636e6df3b85a3a85c47bc4ca64a (patch)
tree7bf3c6a7dac2f105f9d5f9d858f8e77ccf6e153d /changelog.d/4358.misc
parentFix synapse.config.__main__ on python 3 (#4356) (diff)
downloadsynapse-b970cb0e9618c636e6df3b85a3a85c47bc4ca64a.tar.xz
Refactor request sending to have better excpetions (#4358)
* Correctly retry and back off if we get a HTTPerror response

* Refactor request sending to have better excpetions

MatrixFederationHttpClient blindly reraised exceptions to the caller
without differentiating "expected" failures (e.g. connection timeouts
etc) versus more severe problems (e.g. programming errors).

This commit adds a RequestSendFailed exception that is raised when
"expected" failures happen, allowing the TransactionQueue to log them as
warnings while allowing us to log other exceptions as actual exceptions.
Diffstat (limited to 'changelog.d/4358.misc')
-rw-r--r--changelog.d/4358.misc1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/4358.misc b/changelog.d/4358.misc
new file mode 100644
index 0000000000..020dacb547
--- /dev/null
+++ b/changelog.d/4358.misc
@@ -0,0 +1 @@
+Add better logging for unexpected errors while sending transactions