summary refs log tree commit diff
path: root/changelog.d/17386.bugfix
diff options
context:
space:
mode:
authorErik Johnston <erikj@element.io>2024-07-02 12:39:49 +0100
committerErik Johnston <erik@matrix.org>2024-07-02 12:40:03 +0100
commit1ce59d7ba002a869ee94fbe375898cc79c6eb4d1 (patch)
tree40781e146a4bc05fd7e0fbe0bc5d2619c28b7683 /changelog.d/17386.bugfix
parentFix building debian packages for sid (#17389) (diff)
downloadsynapse-1ce59d7ba002a869ee94fbe375898cc79c6eb4d1.tar.xz
Fix sync waiting for an invalid token from the "future" (#17386)
Fixes https://github.com/element-hq/synapse/issues/17274, hopefully.

Basically, old versions of Synapse could advance streams without
persisting anything in the DB (fixed in #17229). On restart those
updates would get lost, and so the position of the stream would revert
to an older position. If this happened across an upgrade to a later
Synapse version which included #17215, then sync could get blocked
indefinitely (until the stream advanced to the position in the token).

We fix this by bounding the stream positions we'll wait for to the
maximum position of the underlying stream ID generator.
Diffstat (limited to 'changelog.d/17386.bugfix')
-rw-r--r--changelog.d/17386.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/17386.bugfix b/changelog.d/17386.bugfix
new file mode 100644
index 0000000000..9686b5c276
--- /dev/null
+++ b/changelog.d/17386.bugfix
@@ -0,0 +1 @@
+Fix bug where `/sync` requests could get blocked indefinitely after an upgrade from Synapse versions before v1.109.0.