diff options
| author | David Robertson <davidr@element.io> | 2023-01-31 10:57:02 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-31 10:57:02 +0000 |
| commit | a134e626e43e9c31a4618d4164ba7d6242c0f803 (patch) | |
| tree | 186eefe970b8f7d493566ec1066672c48928a590 /changelog.d/14944.bugfix | |
| parent | Prefer `type(x) is int` to `isinstance(x, int)` (#14945) (diff) | |
| download | synapse-a134e626e43e9c31a4618d4164ba7d6242c0f803.tar.xz | |
Reject boolean power levels (#14944)
* Better test for bad values in power levels events The previous test only checked that Synapse didn't raise an exception, but didn't check that we had correctly interpreted the value of the dodgy power level. It also conflated two things: bad room notification levels, and bad user levels. There _is_ logic for converting the latter to integers, but we should test it separately. * Check we ignore types that don't convert to int * Handle `None` values in `notifications.room` * Changelog * Also test that bad values are rejected by event auth * Docstring * linter scripttttttttt * Test boolean values in PL content * Reject boolean power levels * Changelog
Diffstat (limited to 'changelog.d/14944.bugfix')
| -rw-r--r-- | changelog.d/14944.bugfix | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/14944.bugfix b/changelog.d/14944.bugfix new file mode 100644 index 0000000000..5fe1fb322b --- /dev/null +++ b/changelog.d/14944.bugfix @@ -0,0 +1 @@ +Fix a bug introduced in Synapse v1.64 where boolean power levels were erroneously permitted in [v10 rooms](https://spec.matrix.org/v1.5/rooms/v10/). |