diff options
| author | Sean Quah <8349537+squahtx@users.noreply.github.com> | 2023-01-13 00:16:21 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-13 00:16:21 +0000 |
| commit | 772e8c23856e27960caba4dd87af42401b6c0cac (patch) | |
| tree | 11d8c1cb6bb8780277d4caa5d67bb2334b0222f4 /changelog.d/14812.bugfix | |
| parent | Merge branch 'release-v1.75' into develop (diff) | |
| download | synapse-772e8c23856e27960caba4dd87af42401b6c0cac.tar.xz | |
Fix stack overflow in `_PerHostRatelimiter` due to synchronous requests (#14812)
When there are many synchronous requests waiting on a `_PerHostRatelimiter`, each request will be started recursively just after the previous request has completed. Under the right conditions, this leads to stack exhaustion. A common way for requests to become synchronous is when the remote client disconnects early, because the homeserver is overloaded and slow to respond. Avoid stack exhaustion under these conditions by deferring subsequent requests until the next reactor tick. Fixes #14480. Signed-off-by: Sean Quah <seanq@matrix.org>
Diffstat (limited to 'changelog.d/14812.bugfix')
| -rw-r--r-- | changelog.d/14812.bugfix | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/14812.bugfix b/changelog.d/14812.bugfix new file mode 100644 index 0000000000..94e0d70cbc --- /dev/null +++ b/changelog.d/14812.bugfix @@ -0,0 +1 @@ +Fix a long-standing bug where Synapse would exhaust the stack when processing many federation requests where the remote homeserver has disconencted early. |