diff options
author | Eric Eastwood <erice@element.io> | 2022-05-23 20:43:37 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-23 20:43:37 -0500 |
commit | 7c2a78bb3bd2091439722e9f1e4601837bcb8fc4 (patch) | |
tree | cd594ff5e93fbbd42cf0b406d46c4bc52bb97951 /changelog.d/12713.bugfix | |
parent | Uniformize spam-checker API, part 2: check_event_for_spam (#12808) (diff) | |
download | synapse-7c2a78bb3bd2091439722e9f1e4601837bcb8fc4.tar.xz |
Marker events as state - MSC2716 (#12718)
Sending marker events as state now so they are always able to be seen by homeservers (not lost in some timeline gap). Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) Complement tests: https://github.com/matrix-org/complement/pull/371 As initially discussed at https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r782629097 and https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r876684431 When someone joins a room, process all of the marker events we see in the current state. Marker events should be sent with a unique `state_key` so that they can all resolve in the current state to easily be discovered. Marker events as state - If we re-use the same `state_key` (like `""`), then we would have to fetch previous snapshots of state up through time to find all of the marker events. This way we can avoid all of that. This PR was originally doing this but then thought of the smarter way to tackle in an [out of band discussion with @erikjohnston](https://docs.google.com/document/d/1JJDuPfcPNX75fprdTWlxlaKjWOdbdJylbpZ03hzo638/edit#bookmark=id.sm92fqyq7vpp). - Also avoids state resolution conflicts where only one of the marker events win As a homeserver, when we see new marker state, we know there is new history imported somewhere back in time and should process it to fetch the insertion event where the historical messages are and set it as an insertion extremity. This way we know where to backfill more messages when someone asks for scrollback.
Diffstat (limited to 'changelog.d/12713.bugfix')
0 files changed, 0 insertions, 0 deletions