summary refs log tree commit diff
path: root/changelog.d/11737.bugfix
diff options
context:
space:
mode:
authorDaniel Sonck <daniel@sonck.nl>2022-01-17 12:42:51 +0100
committerGitHub <noreply@github.com>2022-01-17 11:42:51 +0000
commit6b241f5286f05d4d8dc0569e90388713a956d038 (patch)
treeb79ff27fc7864456285183a11eb4fa3b654d555c /changelog.d/11737.bugfix
parentMerge branch 'release-v1.50' into develop (diff)
downloadsynapse-6b241f5286f05d4d8dc0569e90388713a956d038.tar.xz
Make pagination of rooms in admin api stable (#11737)
Always add state.room_id after the configurable ORDER BY. Otherwise,
for any sort, certain pages can contain results from
other pages. (Especially when sorting by creator, since there may
be many rooms by the same creator)

* Document different order direction of numerical fields

"joined_members", "joined_local_members", "version" and "state_events"
are ordered in descending direction by default (dir=f). Added a note
in tests to explain the differences in ordering.

Signed-off-by: Daniël Sonck <daniel@sonck.nl>
Diffstat (limited to 'changelog.d/11737.bugfix')
-rw-r--r--changelog.d/11737.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/11737.bugfix b/changelog.d/11737.bugfix
new file mode 100644
index 0000000000..a293d1cfec
--- /dev/null
+++ b/changelog.d/11737.bugfix
@@ -0,0 +1 @@
+Make the list rooms admin api sort stable. Contributed by Daniël Sonck.
\ No newline at end of file