summary refs log tree commit diff
path: root/changelog.d/11632.bugfix
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2022-01-04 16:31:32 +0000
committerGitHub <noreply@github.com>2022-01-04 16:31:32 +0000
commit878aa5529399ece8fbb68674a6de86d6958bacae (patch)
tree67f19ff07959dd6f23edbeea1f391d614293660f /changelog.d/11632.bugfix
parentRemove redundant `get_current_events_token` (#11643) (diff)
downloadsynapse-878aa5529399ece8fbb68674a6de86d6958bacae.tar.xz
`FederationClient.backfill`: stop flagging events as outliers (#11632)
Events returned by `backfill` should not be flagged as outliers.

Fixes:

```
AssertionError: null
  File "synapse/handlers/federation.py", line 313, in try_backfill
    dom, room_id, limit=100, extremities=extremities
  File "synapse/handlers/federation_event.py", line 517, in backfill
    await self._process_pulled_events(dest, events, backfilled=True)
  File "synapse/handlers/federation_event.py", line 642, in _process_pulled_events
    await self._process_pulled_event(origin, ev, backfilled=backfilled)
  File "synapse/handlers/federation_event.py", line 669, in _process_pulled_event
    assert not event.internal_metadata.is_outlier()
```

See https://sentry.matrix.org/sentry/synapse-matrixorg/issues/231992

Fixes #8894.
Diffstat (limited to 'changelog.d/11632.bugfix')
-rw-r--r--changelog.d/11632.bugfix1
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/11632.bugfix b/changelog.d/11632.bugfix
new file mode 100644
index 0000000000..c73d41652a
--- /dev/null
+++ b/changelog.d/11632.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in Synapse 1.19.3 which could sometimes cause `AssertionError`s when backfilling rooms over federation.