summary refs log tree commit diff
path: root/changelog.d/10896.misc
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2021-09-28 15:25:07 +0100
committerGitHub <noreply@github.com>2021-09-28 15:25:07 +0100
commit2622b28c5cbe38c60c556544aa7502a8684ee60b (patch)
tree644bd4a67652cf16da4ef6ebdf5dc36c75f447d0 /changelog.d/10896.misc
parentClean-up type hints in server config (#10915) (diff)
downloadsynapse-2622b28c5cbe38c60c556544aa7502a8684ee60b.tar.xz
Inline `_check_event_auth` for outliers (#10926)
* Inline `_check_event_auth` for outliers

When we are persisting an outlier, most of `_check_event_auth` is redundant:

 * `_update_auth_events_and_context_for_auth` does nothing, because the
   `input_auth_events` are (now) exactly the event's auth_events,
   which means that `missing_auth` is empty.

 * we don't care about soft-fail, kicking guest users or `send_on_behalf_of`
   for outliers

... so the only thing that matters is the auth itself, so let's just do that.

* `_auth_and_persist_fetched_events_inner`: de-async `prep`

`prep` no longer calls any `async` methods, so let's make it synchronous.

* Simplify `_check_event_auth`

We no longer need to support outliers here, which makes things rather simpler.

* changelog

* lint
Diffstat (limited to 'changelog.d/10896.misc')
-rw-r--r--changelog.d/10896.misc2
1 files changed, 1 insertions, 1 deletions
diff --git a/changelog.d/10896.misc b/changelog.d/10896.misc
index 41de995842..9a765435db 100644
--- a/changelog.d/10896.misc
+++ b/changelog.d/10896.misc
@@ -1 +1 @@
- Clean up some of the federation event authentication code for clarity.
+Clean up some of the federation event authentication code for clarity.