diff options
author | Erik Johnston <erik@matrix.org> | 2017-04-25 10:23:11 +0100 |
---|---|---|
committer | Erik Johnston <erik@matrix.org> | 2017-04-25 10:23:11 +0100 |
commit | 119cb9bbcf429321d27cbc1422049974e2ad8982 (patch) | |
tree | 70ca3bdbe7c6bc3e8bacafc9ed3948bf685e5086 /UPGRADE.rst | |
parent | Merge pull request #2155 from matrix-org/erikj/string_intern (diff) | |
download | synapse-119cb9bbcf429321d27cbc1422049974e2ad8982.tar.xz |
Reduce cache size by not storing deferreds
Currently the cache descriptors store deferreds rather than raw values, this is a simple way of triggering only one database hit and sharing the result if two callers attempt to get the same value. However, there are a few caches that simply store a mapping from string to string (or int). These caches can have a large number of entries, under the assumption that each entry is small. However, the size of a deferred (specifically the size of ObservableDeferred) is signigicantly larger than that of the raw value, 2kb vs 32b. This PR therefore changes the cache descriptors to store the raw values rather than the deferreds. As a side effect cached storage function now either return a deferred or the actual value, as the cached list decriptor already does. This is fine as we always end up just yield'ing on the returned value eventually, which handles that case correctly.
Diffstat (limited to 'UPGRADE.rst')
0 files changed, 0 insertions, 0 deletions