diff options
| author | Kegan Dougal <7190048+kegsay@users.noreply.github.com> | 2024-04-15 11:57:56 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-15 10:57:56 +0000 |
| commit | 259442fa4c476b32de1e8a0739f5909403c820e4 (patch) | |
| tree | 73a58875b24214b9687688ace87b097bbff9848f /CHANGES.md | |
| parent | Use receipts `event_stream_ordering` instead of joins (#17032) (diff) | |
| download | synapse-259442fa4c476b32de1e8a0739f5909403c820e4.tar.xz | |
bugfix: make msc3967 idempotent (#16943)
MSC3967 was updated recently to make it more robust to network failures: > there is an existing cross-signing master key and it exactly matches the cross-signing master key provided in the request body. If there are any additional keys provided in the request (self signing key, user signing key) they MUST also match the existing keys stored on the server. In other words, the request contains no new keys. If there are new keys, UIA MUST be performed. https://github.com/matrix-org/matrix-spec-proposals/blob/hughns/device-signing-upload-uia/proposals/3967-device-signing-upload-uia.md#proposal This covers the case where the 200 OK is lost in transit so the client retries the upload, only to then get UIA'd. Complement tests: https://github.com/matrix-org/complement/pull/713 - passing example https://github.com/element-hq/synapse/actions/runs/7976948122/job/21778795094?pr=16943#step:7:8820 ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [x] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Co-authored-by: reivilibre <oliverw@matrix.org>
Diffstat (limited to 'CHANGES.md')
0 files changed, 0 insertions, 0 deletions