Merge remote-tracking branch 'origin/release-v1.45' into develop

2 files changed, 2 insertions, 1 deletions

diff --git a/changelog.d/11061.bugfix b/changelog.d/11061.bugfix
new file mode 100644

index 0000000000..26fb643793
--- /dev/null
+++ b/changelog.d/11061.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in Synapse v1.44.0 when logging errors during oEmbed processing.
diff --git a/synapse/rest/media/v1/oembed.py b/synapse/rest/media/v1/oembed.py

index 6d7e1f9064..78b1603f19 100644
--- a/synapse/rest/media/v1/oembed.py
+++ b/synapse/rest/media/v1/oembed.py
@@ -191,7 +191,7 @@ class OEmbedProvider:
 
         except Exception as e:
             # Trap any exception and let the code follow as usual.
-            logger.warning(f"Error parsing oEmbed metadata from {url}: {e:r}")
+            logger.warning("Error parsing oEmbed metadata from %s: %r", url, e)
             open_graph_response = {}
             cache_age = None