Fix bug with reusing 'txn' when persisting event. (#10743)

This will only happen when a server has multiple out of band membership
events in a single room.

2 files changed, 8 insertions, 1 deletions

diff --git a/changelog.d/10743.bugfix b/changelog.d/10743.bugfix
new file mode 100644

index 0000000000..d597a19870
--- /dev/null
+++ b/changelog.d/10743.bugfix
@@ -0,0 +1 @@
+Fix edge case when persisting events into a room where there are multiple events we previously hadn't calculated auth chains for (and hadn't marked as needing to be calculated).
diff --git a/synapse/storage/databases/main/events.py b/synapse/storage/databases/main/events.py

index 40b53274fb..096ae28788 100644
--- a/synapse/storage/databases/main/events.py
+++ b/synapse/storage/databases/main/events.py
@@ -575,7 +575,13 @@ class PersistEventsStore:
 
             missing_auth_chains.clear()
 
-            for auth_id, event_type, state_key, chain_id, sequence_number in txn:
+            for (
+                auth_id,
+                event_type,
+                state_key,
+                chain_id,
+                sequence_number,
+            ) in txn.fetchall():
                 event_to_types[auth_id] = (event_type, state_key)
 
                 if chain_id is None: