diff options
| author | Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | 2021-06-17 15:04:26 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-06-17 15:04:26 +0100 |
| commit | 6f1a28de195445352bb1ffcc5d0a90581a348400 (patch) | |
| tree | 87d617ffc351360809766b1990b909a33c6bd8f1 | |
| parent | Add fields to better debug where events are being soft_failed (#10168) (diff) | |
| download | synapse-6f1a28de195445352bb1ffcc5d0a90581a348400.tar.xz | |
Fix incorrect time magnitude on delayed call (#10195)
Fixes https://github.com/matrix-org/synapse/issues/10030. We were expecting milliseconds where we should have provided a value in seconds. The impact of this bug isn't too bad. The code is intended to count the number of remote servers that the homeserver can see and report that as a metric. This metric is supposed to run initially 1 second after server startup, and every 60s as well. Instead, it ran 1,000 seconds after server startup, and every 60s after startup. This fix allows for the correct metrics to be collected immediately, as well as preventing a random collection 1,000s in the future after startup.
| -rw-r--r-- | changelog.d/10195.bugfix | 1 | ||||
| -rw-r--r-- | synapse/storage/databases/main/roommember.py | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/10195.bugfix b/changelog.d/10195.bugfix new file mode 100644 index 0000000000..01cab1bda8 --- /dev/null +++ b/changelog.d/10195.bugfix @@ -0,0 +1 @@ +Fix a bug introduced in Synpase 1.7.2 where remote server count metrics collection would be incorrectly delayed on startup. Found by @heftig. \ No newline at end of file diff --git a/synapse/storage/databases/main/roommember.py b/synapse/storage/databases/main/roommember.py index 5fc3bb5a7d..2796354a1f 100644 --- a/synapse/storage/databases/main/roommember.py +++ b/synapse/storage/databases/main/roommember.py @@ -90,7 +90,7 @@ class RoomMemberWorkerStore(EventsWorkerStore): 60 * 1000, ) self.hs.get_clock().call_later( - 1000, + 1, self._count_known_servers, ) LaterGauge( |