Fix persist_events to stop leaking opentracing contexts (#10193)

2 files changed, 2 insertions, 1 deletions

diff --git a/changelog.d/10193.misc b/changelog.d/10193.misc
new file mode 100644

index 0000000000..ce9702645d
--- /dev/null
+++ b/changelog.d/10193.misc
@@ -0,0 +1 @@
+Improve OpenTracing for event persistence.
diff --git a/synapse/storage/persist_events.py b/synapse/storage/persist_events.py

index dc38942bb1..051095fea9 100644
--- a/synapse/storage/persist_events.py
+++ b/synapse/storage/persist_events.py
@@ -111,7 +111,7 @@ class _EventPersistQueueItem:
     backfilled: bool
     deferred: ObservableDeferred
 
-    parent_opentracing_span_contexts: List = []
+    parent_opentracing_span_contexts: List = attr.ib(factory=list)
     """A list of opentracing spans waiting for this batch"""
 
     opentracing_span_context: Any = None