summary refs log tree commit diff
diff options
context:
space:
mode:
authorAndrew Morgan <andrew@amorgan.xyz>2020-03-30 19:18:00 +0100
committerAndrew Morgan <andrew@amorgan.xyz>2020-03-31 11:26:37 +0100
commitb5d0b038f4f2400dfd3ca7c698638c9821af6086 (patch)
treee17086cb3011a9a560c6ee1563f15e1329e4d45a
parentOnly setdefault for signatures if device has key_json (diff)
downloadsynapse-b5d0b038f4f2400dfd3ca7c698638c9821af6086.tar.xz
Fix another instance
-rw-r--r--synapse/storage/data_stores/main/devices.py12
1 files changed, 7 insertions, 5 deletions
diff --git a/synapse/storage/data_stores/main/devices.py b/synapse/storage/data_stores/main/devices.py
index 84d8deca18..8af5f7de54 100644
--- a/synapse/storage/data_stores/main/devices.py
+++ b/synapse/storage/data_stores/main/devices.py
@@ -527,14 +527,16 @@ class DeviceWorkerStore(SQLBaseStore):
                 key_json = device.get("key_json", None)
                 if key_json:
                     result["keys"] = db_to_json(key_json)
+
+                    if "signatures" in device:
+                        for sig_user_id, sigs in device["signatures"].items():
+                            result["keys"].setdefault("signatures", {}).setdefault(
+                                sig_user_id, {}
+                            ).update(sigs)
+
                 device_display_name = device.get("device_display_name", None)
                 if device_display_name:
                     result["device_display_name"] = device_display_name
-                if "signatures" in device:
-                    for sig_user_id, sigs in device["signatures"].items():
-                        result["keys"].setdefault("signatures", {}).setdefault(
-                            sig_user_id, {}
-                        ).update(sigs)
 
                 results.append(result)