diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-09-19 15:06:27 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-09-19 15:06:27 +0100 |
| commit | bcd91328692555d85df346c4571085c9b41b8f6a (patch) | |
| tree | 59e528c9a6add0ce3f0abfc8c377141142502f92 | |
| parent | Remove POST method from password reset submit_token endpoint (#6056) (diff) | |
| download | synapse-bcd91328692555d85df346c4571085c9b41b8f6a.tar.xz | |
Undo the deletion of some tables (#6047)
This is a partial revert of #5893. The problem is that if we drop these tables in the same release as removing the code that writes to them, it prevents users users from being able to roll back to a previous release. So let's leave the tables in place for now, and remember to drop them in a subsequent release. (Note that these tables haven't been *read* for *years*, so any missing rows resulting from a temporary upgrade to vNext won't cause a problem.)
| -rw-r--r-- | changelog.d/5893.misc | 2 | ||||
| -rw-r--r-- | changelog.d/6047.misc | 2 | ||||
| -rw-r--r-- | synapse/storage/schema/delta/56/drop_unused_event_tables.sql | 20 |
3 files changed, 3 insertions, 21 deletions
diff --git a/changelog.d/5893.misc b/changelog.d/5893.misc index 07ee4888dc..5ef171cb3e 100644 --- a/changelog.d/5893.misc +++ b/changelog.d/5893.misc @@ -1 +1 @@ -Drop some unused tables. +Stop populating some unused tables. diff --git a/changelog.d/6047.misc b/changelog.d/6047.misc new file mode 100644 index 0000000000..a4cdb8abb3 --- /dev/null +++ b/changelog.d/6047.misc @@ -0,0 +1,2 @@ +Stop populating some unused tables. + diff --git a/synapse/storage/schema/delta/56/drop_unused_event_tables.sql b/synapse/storage/schema/delta/56/drop_unused_event_tables.sql deleted file mode 100644 index 9f09922c67..0000000000 --- a/synapse/storage/schema/delta/56/drop_unused_event_tables.sql +++ /dev/null @@ -1,20 +0,0 @@ -/* Copyright 2019 The Matrix.org Foundation C.I.C. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - --- these tables are never used. -DROP TABLE IF EXISTS room_names; -DROP TABLE IF EXISTS topics; -DROP TABLE IF EXISTS history_visibility; -DROP TABLE IF EXISTS guest_access; |