Fix bug where `StreamChangeCache` would not respect cache factors (#17152)

Annoyingly mypy didn't pick up this typo.

2 files changed, 2 insertions, 1 deletions

diff --git a/changelog.d/17152.bugfix b/changelog.d/17152.bugfix
new file mode 100644

index 0000000000..67aee91672
--- /dev/null
+++ b/changelog.d/17152.bugfix
@@ -0,0 +1 @@
+Fix bug where `StreamChangeCache` would not respect configured cache factors.
diff --git a/synapse/util/caches/stream_change_cache.py b/synapse/util/caches/stream_change_cache.py

index d8253bd942..2079ca789c 100644
--- a/synapse/util/caches/stream_change_cache.py
+++ b/synapse/util/caches/stream_change_cache.py
@@ -115,7 +115,7 @@ class StreamChangeCache:
         """
         new_size = math.floor(self._original_max_size * factor)
         if new_size != self._max_size:
-            self.max_size = new_size
+            self._max_size = new_size
             self._evict()
             return True
         return False