diff options
| author | David Robertson <davidr@element.io> | 2023-09-08 14:50:13 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-09-08 14:50:13 +0100 |
| commit | c1c6c95d72b5c9fc6c0e527eeb6b9d3a59889b16 (patch) | |
| tree | 0856c7a116737cb9455d93f7d5e3850a7116349b | |
| parent | Fix-up incorrect spellings in docs. (#16282) (diff) | |
| download | synapse-c1c6c95d72b5c9fc6c0e527eeb6b9d3a59889b16.tar.xz | |
Log values at DEBUG level with execute_values (#16281)
| -rw-r--r-- | changelog.d/16281.misc | 1 | ||||
| -rw-r--r-- | synapse/storage/database.py | 5 |
2 files changed, 4 insertions, 2 deletions
diff --git a/changelog.d/16281.misc b/changelog.d/16281.misc new file mode 100644 index 0000000000..de48396aff --- /dev/null +++ b/changelog.d/16281.misc @@ -0,0 +1 @@ +Include values in SQL debug when using `execute_values` with Postgres. diff --git a/synapse/storage/database.py b/synapse/storage/database.py index 55ac313f33..6c5fcdcec3 100644 --- a/synapse/storage/database.py +++ b/synapse/storage/database.py @@ -422,10 +422,11 @@ class LoggingTransaction: return self._do_execute( # TODO: is it safe for values to be Iterable[Iterable[Any]] here? # https://www.psycopg.org/docs/extras.html?highlight=execute_batch#psycopg2.extras.execute_values says values should be Sequence[Sequence] - lambda the_sql: execute_values( - self.txn, the_sql, values, template=template, fetch=fetch + lambda the_sql, the_values: execute_values( + self.txn, the_sql, the_values, template=template, fetch=fetch ), sql, + values, ) def execute(self, sql: str, parameters: SQLQueryParameters = ()) -> None: |