diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-06-04 11:53:07 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-06-04 11:53:07 +0100 |
| commit | 4d08b8f30c6a10caaa570bd93059d496b66185a0 (patch) | |
| tree | 705431431f828f5429c4ad800fdc5ffd33bea211 | |
| parent | Merge pull request #5333 from matrix-org/rav/server_keys/09_improve_notary_se... (diff) | |
| download | synapse-4d08b8f30c6a10caaa570bd93059d496b66185a0.tar.xz | |
Don't do long retries when calling the key notary server. (#5334)
It takes at least 20 minutes to work through the long_retries schedule (11 attempts, each with a 60 second timeout, and 60 seconds between each request), so if the notary server isn't returning within the timeout, we'll just end up blocking whatever request is happening for 20 minutes. Ain't nobody got time for that.
| -rw-r--r-- | changelog.d/5334.bugfix | 1 | ||||
| -rw-r--r-- | synapse/crypto/keyring.py | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/changelog.d/5334.bugfix b/changelog.d/5334.bugfix new file mode 100644 index 0000000000..ed141e0918 --- /dev/null +++ b/changelog.d/5334.bugfix @@ -0,0 +1 @@ +Fix bug which would make certain operations (such as room joins) block for 20 minutes while attemoting to fetch verification keys. diff --git a/synapse/crypto/keyring.py b/synapse/crypto/keyring.py index 6dae713ebc..0fd15287e7 100644 --- a/synapse/crypto/keyring.py +++ b/synapse/crypto/keyring.py @@ -644,7 +644,6 @@ class PerspectivesKeyFetcher(BaseV2KeyFetcher): for server_name, server_keys in keys_to_fetch.items() } }, - long_retries=True, ) except (NotRetryingDestination, RequestSendFailed) as e: raise_from(KeyLookupError("Failed to connect to remote server"), e) |