summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2019-10-25 10:28:36 +0100
committerErik Johnston <erik@matrix.org>2019-10-25 10:28:36 +0100
commitf666d6f5d71b34762afc6c3d987496633ff2182c (patch)
tree2428ddd175813a9054b9243cec806eea85fceb8e
parentMerge pull request #6248 from matrix-org/erikj/move_schema_files (diff)
downloadsynapse-f666d6f5d71b34762afc6c3d987496633ff2182c.tar.xz
Remove repeated calls to config.stats_enabled.
Turns out that fetching variables from the config object is expensive,
so doing it once at startup avoids unnecessary work.
-rw-r--r--synapse/handlers/stats.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/synapse/handlers/stats.py b/synapse/handlers/stats.py
index 466daf9202..26bc276692 100644
--- a/synapse/handlers/stats.py
+++ b/synapse/handlers/stats.py
@@ -45,6 +45,8 @@ class StatsHandler(StateDeltasHandler):
         self.is_mine_id = hs.is_mine_id
         self.stats_bucket_size = hs.config.stats_bucket_size
 
+        self.stats_enabled = hs.config.stats_enabled
+
         # The current position in the current_state_delta stream
         self.pos = None
 
@@ -61,7 +63,7 @@ class StatsHandler(StateDeltasHandler):
     def notify_new_event(self):
         """Called when there may be more deltas to process
         """
-        if not self.hs.config.stats_enabled or self._is_processing:
+        if not self.stats_enabled or self._is_processing:
             return
 
         self._is_processing = True