diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-06-04 18:05:06 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-06-04 18:05:06 +0100 |
| commit | dae224a73f6a799718f7dfc5c6d8ac3e050fca1d (patch) | |
| tree | 392e864a4fc70d3625b5e5211d2782cad3416d82 | |
| parent | Rename get_events->get_events_from_store_or_dest (#5344) (diff) | |
| download | synapse-dae224a73f6a799718f7dfc5c6d8ac3e050fca1d.tar.xz | |
Fix failure to fetch batches of PDUs (#5342)
FederationClient.get_pdu is called in a loop to fetch a batch of PDUs. A failure to fetch one should not result in a failure of the whole batch. Add the missing `continue`.
| -rw-r--r-- | changelog.d/5342.bugfix | 1 | ||||
| -rw-r--r-- | synapse/federation/federation_client.py | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/changelog.d/5342.bugfix b/changelog.d/5342.bugfix new file mode 100644 index 0000000000..66a3076292 --- /dev/null +++ b/changelog.d/5342.bugfix @@ -0,0 +1 @@ +Fix failure when fetching batches of events during backfill, etc. diff --git a/synapse/federation/federation_client.py b/synapse/federation/federation_client.py index 916ff487c9..d559605382 100644 --- a/synapse/federation/federation_client.py +++ b/synapse/federation/federation_client.py @@ -279,6 +279,7 @@ class FederationClient(FederationBase): "Failed to get PDU %s from %s because %s", event_id, destination, e, ) + continue except NotRetryingDestination as e: logger.info(str(e)) continue |