diff options
| author | Patrick Cloke <clokep@users.noreply.github.com> | 2021-10-12 13:15:42 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-12 17:15:42 +0000 |
| commit | 1db9282dfa3976497d4208c1d84dd1796e529332 (patch) | |
| tree | 96b12e8c8635cdebef4f73525687d80e5a862060 | |
| parent | Fix race in `MultiWriterIdGenerator` (#11045) (diff) | |
| download | synapse-1db9282dfa3976497d4208c1d84dd1796e529332.tar.xz | |
Fix formatting string when oEmbed errors occur. (#11061)
| -rw-r--r-- | changelog.d/11061.bugfix | 1 | ||||
| -rw-r--r-- | synapse/rest/media/v1/oembed.py | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/11061.bugfix b/changelog.d/11061.bugfix new file mode 100644 index 0000000000..26fb643793 --- /dev/null +++ b/changelog.d/11061.bugfix @@ -0,0 +1 @@ +Fix a bug introduced in Synapse v1.44.0 when logging errors during oEmbed processing. diff --git a/synapse/rest/media/v1/oembed.py b/synapse/rest/media/v1/oembed.py index 6d7e1f9064..78b1603f19 100644 --- a/synapse/rest/media/v1/oembed.py +++ b/synapse/rest/media/v1/oembed.py @@ -191,7 +191,7 @@ class OEmbedProvider: except Exception as e: # Trap any exception and let the code follow as usual. - logger.warning(f"Error parsing oEmbed metadata from {url}: {e:r}") + logger.warning("Error parsing oEmbed metadata from %s: %r", url, e) open_graph_response = {} cache_age = None |