summary refs log tree commit diff
diff options
context:
space:
mode:
authorPaul "LeoNerd" Evans <paul@matrix.org>2016-08-18 17:24:39 +0100
committerPaul "LeoNerd" Evans <paul@matrix.org>2016-08-18 17:24:39 +0100
commit697872cf087d983d77e7c2174ad71361f703fb49 (patch)
tree9ed2fb87fe92e2f77f2e1baa21202be01dee4838
parentAvoid so much copypasta between 3PU and 3PL query by unifying around a ThirdP... (diff)
downloadsynapse-697872cf087d983d77e7c2174ad71361f703fb49.tar.xz
More warnings about invalid results from AS 3PE query
-rw-r--r--synapse/handlers/appservice.py9
1 files changed, 7 insertions, 2 deletions
diff --git a/synapse/handlers/appservice.py b/synapse/handlers/appservice.py
index 52c127d2c1..6f162a3c00 100644
--- a/synapse/handlers/appservice.py
+++ b/synapse/handlers/appservice.py
@@ -187,15 +187,20 @@ class ApplicationServicesHandler(object):
         ret = []
         for (success, result) in results:
             if not success:
+                logger.warn("Application service failed %r", result)
                 continue
             if not isinstance(result, list):
+                logger.warn(
+                    "Application service returned an invalid response %r", result
+                )
                 continue
             for r in result:
                 if _is_valid_3pentity_result(r, field=required_field):
                     ret.append(r)
                 else:
-                    logger.warn("Application service returned an " +
-                                "invalid result %r", r)
+                    logger.warn(
+                        "Application service returned an invalid result %r", r
+                    )
 
         defer.returnValue(ret)