diff options
| author | Amber Brown <hawkowl@atleastfornow.net> | 2019-02-27 14:35:47 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-02-27 14:35:47 -0800 |
| commit | b131cc77dfd53c2f66cb6e2399a6b10024cf24cd (patch) | |
| tree | 0a142bdb45923466eb9f4077c6f97cb30ccdfaa0 | |
| parent | Fix parsing of Content-Disposition headers (#4763) (diff) | |
| download | synapse-b131cc77dfd53c2f66cb6e2399a6b10024cf24cd.tar.xz | |
Make 'event_id' a required parameter in federated state requests (#4741)
* make 'event_id' a required parameter in federated state requests As per the spec: https://matrix.org/docs/spec/server_server/r0.1.1.html#id40 Signed-off-by: Joseph Weston <joseph@weston.cloud> * add changelog entry for bugfix Signed-off-by: Joseph Weston <joseph@weston.cloud> * Update server.py
| -rw-r--r-- | changelog.d/4740.bugfix | 1 | ||||
| -rw-r--r-- | synapse/federation/transport/server.py | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/changelog.d/4740.bugfix b/changelog.d/4740.bugfix new file mode 100644 index 0000000000..f82bb4227a --- /dev/null +++ b/changelog.d/4740.bugfix @@ -0,0 +1 @@ +'event_id' is now a required parameter in federated state requests, as per the matrix spec. diff --git a/synapse/federation/transport/server.py b/synapse/federation/transport/server.py index 5ba94be2ec..ebb81be377 100644 --- a/synapse/federation/transport/server.py +++ b/synapse/federation/transport/server.py @@ -393,7 +393,7 @@ class FederationStateServlet(BaseFederationServlet): return self.handler.on_context_state_request( origin, context, - parse_string_from_args(query, "event_id", None), + parse_string_from_args(query, "event_id", None, required=True), ) @@ -404,7 +404,7 @@ class FederationStateIdsServlet(BaseFederationServlet): return self.handler.on_state_ids_request( origin, room_id, - parse_string_from_args(query, "event_id", None), + parse_string_from_args(query, "event_id", None, required=True), ) |