summary refs log tree commit diff
diff options
context:
space:
mode:
authorL0ric0 <L0ric0@users.noreply.github.com>2019-09-02 13:18:41 +0200
committerRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2019-09-02 12:18:41 +0100
commitce7803b8b030f7359dd1c394d1c874dbfdd79f36 (patch)
tree18296f0d4f306acaac71d83fc2b281a85fbcb079
parentUpdate INSTALL.md to say that Python 2 is no longer supported (#5953) (diff)
downloadsynapse-ce7803b8b030f7359dd1c394d1c874dbfdd79f36.tar.xz
fix thumbnail storage location (#5915)
* fix thumbnail storage location

Signed-off-by: Lorenz Steinert <lorenz@steinerts.de>

* Add changelog file.

Signed-off-by: Lorenz Steinert <lorenz@steinerts.de>

* Update Changelog

Signed-off-by: Lorenz Steinert <lorenz@steinerts.de>
-rw-r--r--changelog.d/5915.bugfix1
-rw-r--r--synapse/rest/media/v1/media_repository.py2
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/5915.bugfix b/changelog.d/5915.bugfix
new file mode 100644
index 0000000000..bf5b99fedc
--- /dev/null
+++ b/changelog.d/5915.bugfix
@@ -0,0 +1 @@
+Fix 404 for thumbnail download when `dynamic_thumbnails` is `false` and the thumbnail was dynamically generated. Fix reported by rkfg.
diff --git a/synapse/rest/media/v1/media_repository.py b/synapse/rest/media/v1/media_repository.py
index d4ea09260c..b972e152a9 100644
--- a/synapse/rest/media/v1/media_repository.py
+++ b/synapse/rest/media/v1/media_repository.py
@@ -526,7 +526,7 @@ class MediaRepository(object):
             try:
                 file_info = FileInfo(
                     server_name=server_name,
-                    file_id=media_id,
+                    file_id=file_id,
                     thumbnail=True,
                     thumbnail_width=t_width,
                     thumbnail_height=t_height,