summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2017-03-28 13:20:15 +0100
committerErik Johnston <erik@matrix.org>2017-03-28 13:27:21 +0100
commit30f5ffdca2a610c7b47dd9aaa02f1fa91976775f (patch)
tree5577483a5d663e6f653a327a4f1f3b777fc2b748
parentCompile the regex's used in ASes (diff)
downloadsynapse-30f5ffdca2a610c7b47dd9aaa02f1fa91976775f.tar.xz
Remove param and cast at call site
-rw-r--r--synapse/appservice/__init__.py14
1 files changed, 6 insertions, 8 deletions
diff --git a/synapse/appservice/__init__.py b/synapse/appservice/__init__.py
index 1e298ccf36..885d14fa91 100644
--- a/synapse/appservice/__init__.py
+++ b/synapse/appservice/__init__.py
@@ -133,16 +133,14 @@ class ApplicationService(object):
                     )
         return namespaces
 
-    def _matches_regex(self, test_string, namespace_key, return_obj=False):
+    def _matches_regex(self, test_string, namespace_key):
         for regex_obj in self.namespaces[namespace_key]:
             if regex_obj["regex"].match(test_string):
-                if return_obj:
-                    return regex_obj
-                return True
-        return False
+                return regex_obj
+        return None
 
     def _is_exclusive(self, ns_key, test_string):
-        regex_obj = self._matches_regex(test_string, ns_key, return_obj=True)
+        regex_obj = self._matches_regex(test_string, ns_key)
         if regex_obj:
             return regex_obj["exclusive"]
         return False
@@ -215,10 +213,10 @@ class ApplicationService(object):
         )
 
     def is_interested_in_alias(self, alias):
-        return self._matches_regex(alias, ApplicationService.NS_ALIASES)
+        return bool(self._matches_regex(alias, ApplicationService.NS_ALIASES))
 
     def is_interested_in_room(self, room_id):
-        return self._matches_regex(room_id, ApplicationService.NS_ROOMS)
+        return bool(self._matches_regex(room_id, ApplicationService.NS_ROOMS))
 
     def is_exclusive_user(self, user_id):
         return (