diff options
| author | Erik Johnston <erikj@element.io> | 2024-01-10 13:53:20 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-10 13:53:20 +0000 |
| commit | 8189942a1fe1bf53eb771158628abf786c195bfa (patch) | |
| tree | fbfe73969f839075c8bee6db2109dc1a8fe8d6de | |
| parent | Add a link to the Request log format page from Logging Sample Config (#16778) (diff) | |
| download | synapse-8189942a1fe1bf53eb771158628abf786c195bfa.tar.xz | |
Remove CI check for sign off (#16776)
Since we don't require one anymore.
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 1 | ||||
| -rw-r--r-- | .github/workflows/tests.yml | 7 | ||||
| -rw-r--r-- | changelog.d/16776.misc | 1 |
3 files changed, 2 insertions, 7 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 41503899a1..07d4f6dfce 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,6 +9,5 @@ - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. -* [ ] Pull request includes a [sign off](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#sign-off) * [ ] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f22ca5f7e6..024d18bd0f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,10 +12,6 @@ concurrency: cancel-in-progress: true jobs: - check-signoff: - if: "github.event_name == 'pull_request'" - uses: "matrix-org/backend-meta/.github/workflows/sign-off.yml@v2" - # Job to detect what has changed so we don't run e.g. Rust checks on PRs that # don't modify Rust code. changes: @@ -706,7 +702,7 @@ jobs: needs: ${{ toJSON(needs) }} # Various bits are skipped if there was no applicable changes. - # The newsfile and signoff lint may be skipped on non PR builds. + # The newsfile lint may be skipped on non PR builds. skippable: | trial trial-olddeps @@ -714,7 +710,6 @@ jobs: portdb export-data complement - check-signoff lint-newsfile cargo-test cargo-bench diff --git a/changelog.d/16776.misc b/changelog.d/16776.misc new file mode 100644 index 0000000000..1650075a77 --- /dev/null +++ b/changelog.d/16776.misc @@ -0,0 +1 @@ +Remove CI check for sign off as we require an CLA signature instead. |