summary refs log tree commit diff
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2017-10-11 14:25:16 +0100
committerRichard van der Hoff <richard@matrix.org>2017-10-11 14:36:13 +0100
commitb75d443caff63a736e914236ef7448c9502e6495 (patch)
treec0b2c2c8cf0d09a4b25c5133d3bf3afbbdd39182
parentMerge pull request #2517 from matrix-org/rav/fed_server_refactor (diff)
downloadsynapse-b75d443caff63a736e914236ef7448c9502e6495.tar.xz
log pdu_failures from incoming transactions
... even if we have no EDUs.

This appears to have been introduced in
476899295f5fd6cff64799bcbc84cd4bf9005e33.
-rw-r--r--synapse/federation/federation_server.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/synapse/federation/federation_server.py b/synapse/federation/federation_server.py
index fa4ec2ad3c..b4b587c867 100644
--- a/synapse/federation/federation_server.py
+++ b/synapse/federation/federation_server.py
@@ -168,8 +168,9 @@ class FederationServer(FederationBase):
                     edu.content
                 )
 
-            for failure in getattr(transaction, "pdu_failures", []):
-                logger.info("Got failure %r", failure)
+        pdu_failures = getattr(transaction, "pdu_failures", [])
+        for failure in pdu_failures:
+            logger.info("Got failure %r", failure)
 
         response = {
             "pdus": pdu_results,