summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2015-11-20 14:05:22 +0000
committerErik Johnston <erik@matrix.org>2015-11-20 14:05:22 +0000
commite3dae653e89d7c8cc036eacb1ff7c02e4c55a76b (patch)
tree1d9a704f8f9dd07ca21a60a78ea4c8b3c5cb5d0b
parentRemove m.login.token from advertised flows. (diff)
downloadsynapse-e3dae653e89d7c8cc036eacb1ff7c02e4c55a76b.tar.xz
Comment
-rw-r--r--synapse/rest/client/v1/login.py8
1 files changed, 8 insertions, 0 deletions
diff --git a/synapse/rest/client/v1/login.py b/synapse/rest/client/v1/login.py
index d6d2ebaba1..720d6358e7 100644
--- a/synapse/rest/client/v1/login.py
+++ b/synapse/rest/client/v1/login.py
@@ -58,6 +58,14 @@ class LoginRestServlet(ClientV1RestServlet):
             flows.append({"type": LoginRestServlet.SAML2_TYPE})
         if self.cas_enabled:
             flows.append({"type": LoginRestServlet.CAS_TYPE})
+
+            # While its valid for us to advertise this login type generally,
+            # synapse currently only gives out these tokens as part of the
+            # CAS login flow.
+            # Generally we don't want to advertise login flows that clients
+            # don't know how to implement, since they (currently) will always
+            # fall back to the fallback API if they don't understand one of the
+            # login flow types returned.
             flows.append({"type": LoginRestServlet.TOKEN_TYPE})
         if self.password_enabled:
             flows.append({"type": LoginRestServlet.PASS_TYPE})