summary refs log tree commit diff
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2019-09-25 11:24:44 +0100
committerRichard van der Hoff <richard@matrix.org>2019-09-25 11:24:44 +0100
commit1ecf6e2286c86c19671e5648cf438dd5eaba3be4 (patch)
tree6ac73b1f45462867e7771bd424141b3c9c78ed1e
parentMerge branch 'rav/refactor_ui_auth' into neilj/fix_check_threepid_for_msisdns (diff)
downloadsynapse-1ecf6e2286c86c19671e5648cf438dd5eaba3be4.tar.xz
address ryan's review comment
-rw-r--r--synapse/handlers/ui_auth/checkers.py7
1 files changed, 3 insertions, 4 deletions
diff --git a/synapse/handlers/ui_auth/checkers.py b/synapse/handlers/ui_auth/checkers.py
index 9b802ea265..72faa9ae54 100644
--- a/synapse/handlers/ui_auth/checkers.py
+++ b/synapse/handlers/ui_auth/checkers.py
@@ -145,10 +145,9 @@ class _BaseThreepidAuthChecker:
                 )
         elif medium == "email":
             if self.hs.config.threepid_behaviour_email == ThreepidBehaviour.REMOTE:
-                if medium == "email":
-                    threepid = yield identity_handler.threepid_from_creds(
-                        self.hs.config.account_threepid_delegate_email, threepid_creds
-                    )
+                threepid = yield identity_handler.threepid_from_creds(
+                    self.hs.config.account_threepid_delegate_email, threepid_creds
+                )
             elif self.hs.config.threepid_behaviour_email == ThreepidBehaviour.LOCAL:
                 row = yield self.store.get_threepid_validation_session(
                     medium,