diff options
| author | Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | 2020-09-29 16:42:25 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-09-29 16:42:25 +0100 |
| commit | e154f7ccb5591fab3a5d9072728922d9fa79cfe9 (patch) | |
| tree | 698661060f34665eef231cccce6d737f427c3649 | |
| parent | Don't table scan events on worker startup (#8419) (diff) | |
| parent | Merge branch 'develop' of github.com:matrix-org/synapse into anoa/info-mainli... (diff) | |
| download | synapse-e154f7ccb5591fab3a5d9072728922d9fa79cfe9.tar.xz | |
Don't check whether a 3pid is allowed to register during password reset (#8414)
* Don't check whether a 3pid is allowed to register during password reset This endpoint should only deal with emails that have already been approved, and are attached with user's account. There's no need to re-check them here. * Changelog
| -rw-r--r-- | changelog.d/8414.bugfix | 1 | ||||
| -rw-r--r-- | synapse/rest/client/v2_alpha/account.py | 7 |
2 files changed, 1 insertions, 7 deletions
diff --git a/changelog.d/8414.bugfix b/changelog.d/8414.bugfix new file mode 100644 index 0000000000..315876e892 --- /dev/null +++ b/changelog.d/8414.bugfix @@ -0,0 +1 @@ +Remove unnecessary 3PID registration check when resetting password via an email address. Bug introduced in v0.34.0rc2. \ No newline at end of file diff --git a/synapse/rest/client/v2_alpha/account.py b/synapse/rest/client/v2_alpha/account.py index 9245214f36..ab5815e7f7 100644 --- a/synapse/rest/client/v2_alpha/account.py +++ b/synapse/rest/client/v2_alpha/account.py @@ -96,13 +96,6 @@ class EmailPasswordRequestTokenRestServlet(RestServlet): send_attempt = body["send_attempt"] next_link = body.get("next_link") # Optional param - if not check_3pid_allowed(self.hs, "email", email): - raise SynapseError( - 403, - "Your email domain is not authorized on this server", - Codes.THREEPID_DENIED, - ) - if next_link: # Raise if the provided next_link value isn't valid assert_valid_next_link(self.hs, next_link) |